Skip to content

chore: move over rest of doc and src files #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 27, 2025

Conversation

kwagoner94
Copy link

No description provided.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (migration@a7c4a9d). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             migration     #168   +/-   ##
============================================
  Coverage             ?   76.47%           
============================================
  Files                ?        3           
  Lines                ?       51           
  Branches             ?        0           
============================================
  Hits                 ?       39           
  Misses               ?       12           
  Partials             ?        0           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean PR! I left a couple of comments


tutorial/index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep old, remove new.

=================
Table of contents
=================
.. toctree::
:maxdepth: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep the old ones here and below.

@sbillinge
Copy link
Contributor

I am merging this as it is. As a general note, when we update copyright dates, we don't delete the old date and replace with the new date (i.e., delete 2024 and replace with 2025) but we keep the old date and add the new date, thus: 2024 -> 2024-2025. This package has not been released since we updated it so I think it is not worth going back to fix that here, so this is just "for the future".

@sbillinge sbillinge merged commit 5db831d into diffpy:migration Jun 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants