Skip to content

chore: move necessary files over to scaffold #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 24, 2025

Conversation

kwagoner94
Copy link

No description provided.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (migration@451da4d). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             migration     #166   +/-   ##
============================================
  Coverage             ?   76.47%           
============================================
  Files                ?        3           
  Lines                ?       51           
  Branches             ?        0           
============================================
  Hits                 ?       39           
  Misses               ?       12           
  Partials             ?        0           
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace the scikit-package png image in the img folder with an empty file called .placeholder. Likewise, remove the example file from snippers and replace it with a .placeholder file. You can generate these with the touch command in bash.

Other than that there is just one comment inline that needs attention I think and then I can merge this. Huge PR! Nicely done.

@sbillinge sbillinge merged commit a7c4a9d into diffpy:migration Jun 24, 2025
2 checks passed
@kwagoner94 kwagoner94 deleted the modified_one branch June 24, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants