skpkg: set up scaffold and moved over docs, src, tests, news #165
Conversation
There was a problem hiding this comment.
this is a great start! In general, pay close attention to things that appear as deleted in these modified files. We often want to keep things from the old package that are being deleted. OK if you miss some, that is what I am here for, and feel free to ask questions.
| @@ -6,22 +6,20 @@ build-backend = "setuptools.build_meta" | |||
| name = "diffpy.srmise" | |||
| dynamic=['version', 'dependencies'] | |||
| authors = [ | |||
| { name="Simon J.L. Billinge group", email="simon.billinge@gmail.com" }, | |||
| {name="Luke Granlund", email="granlund@pa.msu.edu"}, | |||
There was a problem hiding this comment.
we want to keep Luke's name. We never want to "drop" authors.
pyproject.toml
Outdated
| readme = "README.rst" | ||
| requires-python = ">=3.11, <3.14" | ||
| classifiers = [ | ||
| 'Development Status :: 3 - Alpha', | ||
| 'Development Status :: 5 - Production/Stable', |
There was a problem hiding this comment.
this should probably stay as 3 or 4
pyproject.toml
Outdated
| @@ -45,9 +42,6 @@ template = "{tag}" | |||
| dev_template = "{tag}" | |||
| dirty_template = "{tag}" | |||
|
|
|||
| [project.scripts] | |||
|
Ok seems like I missed those. Will keep an eye out in the future |
|
They are honestly easy to catch by looking at the PR on github.... |
|
Ok I see. I will double check the files changed before making the PR in the future |
|
In a case like this, should I go back and fix the files that were modified? |
|
I have fixed the file |
|
nice @kwagoner94 perfectly done. sync your main to upstream and let's go to the next step. |
No description provided.