Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13, drop 3.10 #143

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Support Python 3.13, drop 3.10 #143

merged 6 commits into from
Oct 24, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Oct 24, 2024

PLEASE READ FOR GITHUB MAINTAINERS:

If your package supports Python 3.10, 3.11, 3.12:

  • add requires-python = ">=3.10, <3.13"

If your package supports Python 3.11, 3.12, 3.13:

  • add requires-python = ">=3.11, <3.14"

For this PR reviewer:

Closes #144

conda create -n diffpy.srmise_env python=3.13
conda install --file requirements/conda.txt --file requirements/test.txt
pip install -e . --no-deps

Testing result:

Screenshot 2024-10-24 at 2 41 23 PM

No changes were needed.

@bobleesj bobleesj marked this pull request as ready for review October 24, 2024 18:45
@bobleesj
Copy link
Contributor Author

@sbillinge ready for review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talking to Tieqiong, we realize that in the toml file we want the line requires-python = ">=3.10" to be changed to 3.11 but also a <=3.13 (not sure the right syntax). In the future when conda-forge migrates to the next python version this will then fail with an unresolved error and not just break in the code.

This applies to all the packages so we need to let everyone know and have them update their packages this way.

Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge ready for review - requires-python = ">=3.11, <=3.13" added

@bobleesj
Copy link
Contributor Author

@sbillinge Added an news item for requires-python = ">=3.11, <=3.13", ready for review

@bobleesj
Copy link
Contributor Author

@sbillinge Okay - >=3.11, <3.14 added. Just need to fix the issue titles

@bobleesj
Copy link
Contributor Author

@sbillinge Updated the news file as provided in the general group channel. Ready for review

@sbillinge sbillinge merged commit c60c04a into diffpy:main Oct 24, 2024
3 checks passed
@bobleesj bobleesj deleted the 313 branch October 25, 2024 00:05
@bobleesj bobleesj mentioned this pull request Oct 25, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update requires-python in pyproject.toml
2 participants