Fix rest of flake8 error lambda functions (E731) #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Aug 24, 2024
| and cls not in excluded_types | ||
| ) | ||
|
|
||
| def is_exported_type(cls): |
There was a problem hiding this comment.
__wrapSrFitOperators is a public function and I decided to make is_exported_type nested as well to encapsulate.
| calculate_pr = lambda x: self._invertor.pr(c, x) | ||
| pr = map(calculate_pr, r) | ||
|
|
||
| pr = map(lambda x: self._invertor.pr(c, x), r) |
There was a problem hiding this comment.
Directly inserted the lambda inside the map.
| @@ -270,7 +270,7 @@ def test_releaseOldEquations(self): | |||
| def test_registerFunction(self): | |||
| """Ensure registered function works after second setEquation call.""" | |||
| fc = self.fitcontribution | |||
| fsquare = lambda x: x**2 | |||
| fsquare = lambda x: x**2 # noqa: E731 | |||
There was a problem hiding this comment.
For testing, its usage seems ok, adding noqa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last bit of all flake8 remaining in
cookie.Tests pass