Skip to content

Fix flake8 error of unambiguous variable names and "not xxx in" expression (E741, E713) #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2024
Merged

Fix flake8 error of unambiguous variable names and "not xxx in" expression (E741, E713) #77

merged 4 commits into from
Aug 21, 2024

Conversation

bobleesj
Copy link

Test passes

imac@imacs-iMac diffpy.srfit % python -m diffpy.srfit.tests.run
WARNING:diffpy.srfit.tests:No module named 'sas', SaS tests skipped.
WARNING:diffpy.srfit.tests:Cannot import pyobjcryst, pyobjcryst tests skipped.
WARNING:diffpy.srfit.tests:Cannot import diffpy.srreal, PDF tests skipped.
......ssss................................sssssssssss....ssssss...........................sss..s..............
----------------------------------------------------------------------
Ran 110 tests in 0.195s

OK (skipped=25)

bobleesj
bobleesj commented Aug 21, 2024
View reviewed changes
Copy link
Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review @sbillinge

The only error now left is lambda expression - time to work on that.

src/diffpy/srfit/equation/builder.py
tok in self.builders # Check registered builders
or tok in EquationFactory.symbols # Check symbols
or tok in EquationFactory.ignore # Check ignored characters
):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done automatically by black .

@bobleesj bobleesj marked this pull request as ready for review August 21, 2024 01:52
@sbillinge sbillinge merged commit 563de3f into diffpy:cookie Aug 21, 2024
1 check failed
@bobleesj bobleesj changed the title Fix flake8 error of unambigous variable names and "not xxx in" expression (E741, E713) Fix flake8 error of unambiguous variable names and "not xxx in" expression (E741, E713) Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobleesj @sbillinge