Pass unit tests on Python 3.7 #71
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes two 2 failed test cases using the
diffpy-cmi
Conda environmentWhen
op._value = None
,getValue()
returnsTypeError
instead ofValueError
.Ideally, we use
ValueError
as it was originally; we shall backburner this after we do cookiecutting. I will leave an issue.Local test:
All 110 tests pass.
Conda enviornment (used
conda install diffpy-cmi
)In the next PRs, I will submit flake8 autolinted for few files at a time.