-
Notifications
You must be signed in to change notification settings - Fork 4
skpkg: setup CI after migrating src, tests, requirements, and .github directory #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
@sbillinge @zmx27, there are some problems with the tests. After checking the pre-migration code, I found that the tests were failing before I started the migration process. I also noticed that the tests appear to be headless even though the older tests-on-pr workflow marked them as non-headless. I'm not exactly sure how to mitigate these issues. Could you please advise? |
ok, I will take a look. |
@dabeycorn the changes all look good so I will merge this with tests failing so we have all these linting changes. |
@dabeycorn the test failings are legit. I don't think it needs to run headless tbh, but we have to fix the tests. Let's work on that in the next PR. Please sync the migration branch and we can work on that. Have a look at it yourself and see if you can figure it out. I can help with comments in any resulting PR. If we can't figure it out, I can try and pull it locally and work on it, but see if you can make progress with @zmx27 first. |
Sounds good, I'll take a look at the failing tests |
@dabeycorn After cloning the repo locally and taking a look at the errors, I believe that the |
No description provided.