skpkg: setup CI after migrating tests, src, requirements, and .github directory #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
sbillinge
reviewed
Jun 28, 2025
There was a problem hiding this comment.
PR looks perfect! Just a bit dirty with unwanted merges and reverts and having to pass pre-commit in CI.
I suggest that you close this, and quickly redo it. Make sure to start from a fully synced migration (always, always, always do this. Make it second nature) . Redo the package create as it looks as if you got at least one of the questions wrong (no gui), and possibly others.
Finally, run pre-commit install in your local after you move over the .pre-commit-config.yml so pre-commit changes are running locally and not just in CI. This is preferrable.
|
I understand and will redo it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.