Skip to content

updated functions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2024
Merged

updated functions #5

merged 2 commits into from
Mar 28, 2024

Conversation

yucongalicechen
Copy link
Collaborator

  • modified variable names and used DO for calculation
  • The function compute_cve might still be a bit confusing because there is no cve variable (used muls=1/cve instead)

@yucongalicechen
Copy link
Collaborator Author

  • Copied functions from absorption package to the start of functions.py (didn't change anything from the original absorption package - we might not want to change muls to cve because we need to calculate the sum of muls to get cve=1/sum(muls))
  • Added docstring for set_distances_at_angle, set_muls_at_angle, compute_cve, and apply_corr

@sbillinge sbillinge merged commit b6f7843 into diffpy:main Mar 28, 2024
@sbillinge sbillinge deleted the package branch March 28, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants