Convert SpotlessTaskModern to use InputChanges API

[bigdaz]

This minimal change updates the task to use the non-deprecated
InputChanges API, making it compatible with an upcoming Gradle 7.0
release. This addresses one part of #601.

I haven't updated CHANGES.md since "spotlessModern" is not yet mentioned.

[nedtwigg]

Looks like ConfigAvoidanceTest is failing for the modern implementation. You can put @Category(ExcludeFromPluginGradleModern.class) on it, or you can detect this:

spotless/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GradleIntegrationHarness.java

Line 82 in 495aa3f

if ("true".equals(System.getProperty(SpotlessPluginModern.SPOTLESS_MODERN))) {

and change the test as necessary. Feel free to modify GradleIntegrationHarness as necessary if it makes testing easier.

[bigdaz]

I didn't have a chance to investigate: does it makes sense that this test fails?

Passes on JDK 11: https://scans.gradle.com/s/doieryq3v5kp6
Fails on JDK8: https://scans.gradle.com/s/ue2kfzw3ipgam

[nedtwigg]

I would expect it to fail for both.

spotless/plugin-gradle/src/test/java/com/diffplug/gradle/spotless/ConfigAvoidanceTest.java

Line 26 in 495aa3f

return gradleRunner().withGradleVersion(SpotlessPluginPreConfigAvoidance.CONFIG_AVOIDANCE_INTRODUCED.getVersion());

spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessPluginPreConfigAvoidance.java

Line 24 in 495aa3f

static final GradleVersion CONFIG_AVOIDANCE_INTRODUCED = GradleVersion.version("4.9");

and InputChanges was introduced in 5.4

[nedtwigg]

Wow, what an elegant solution! This looks ready to merge to me, feel free to push merge whenever you'd like (or ask me if you'd prefer not to accept the committer invite I just sent you).

[bigdaz]

Thanks @nedtwigg. I've accepted your invite to the Diffplug org, but I want to state up front that I'm very unlikely to have capacity to stay involved in the development of Spotless long-term. My goal is to get the plugin into a good state and work well with the Gradle remote cache, then I'll probably disappear.

But it's certainly nice to be asked :).

[nedtwigg]

Sounds great! Being a committer on the Spotless team comes with no duties, only privileges :) Now you can restart a failed CI job if you think it was flaky, merge-at-will, etc. If you can figure out how to make a project loosely-coupled (as we have for Spotless), then I think the ideas of OPEN open source are useful.