Skip to content

Commit a392c72

Browse files
committed
Clean up BaseKotlinExtension
1 parent 4597085 commit a392c72

File tree

1 file changed

+19
-22
lines changed

1 file changed

+19
-22
lines changed

plugin-gradle/src/main/java/com/diffplug/gradle/spotless/BaseKotlinExtension.java

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
import com.diffplug.spotless.kotlin.KtLintStep;
3232
import com.diffplug.spotless.kotlin.KtfmtStep;
3333

34-
public abstract class BaseKotlinExtension extends FormatExtension {
35-
public BaseKotlinExtension(SpotlessExtension spotless) {
34+
abstract class BaseKotlinExtension extends FormatExtension {
35+
protected BaseKotlinExtension(SpotlessExtension spotless) {
3636
super(spotless);
3737
}
3838

@@ -70,11 +70,10 @@ public KtfmtConfig ktfmt(String version) {
7070
protected abstract boolean isScript();
7171

7272
public class DiktatConfig {
73-
7473
private final String version;
7574
private FileSignature config;
7675

77-
DiktatConfig(String version) {
76+
private DiktatConfig(String version) {
7877
Objects.requireNonNull(version, "version");
7978
this.version = version;
8079
addStep(createStep());
@@ -97,24 +96,17 @@ private FormatterStep createStep() {
9796
}
9897

9998
public class KtfmtConfig {
100-
final String version;
101-
KtfmtStep.Style style;
102-
KtfmtStep.KtfmtFormattingOptions options;
103-
99+
private final String version;
104100
private final ConfigurableStyle configurableStyle = new ConfigurableStyle();
101+
private KtfmtStep.Style style;
102+
private KtfmtStep.KtfmtFormattingOptions options;
105103

106-
KtfmtConfig(String version) {
104+
private KtfmtConfig(String version) {
107105
Objects.requireNonNull(version);
108106
this.version = Objects.requireNonNull(version);
109107
addStep(createStep());
110108
}
111109

112-
private ConfigurableStyle style(KtfmtStep.Style style) {
113-
this.style = style;
114-
replaceStep(createStep());
115-
return configurableStyle;
116-
}
117-
118110
public ConfigurableStyle dropboxStyle() {
119111
return style(KtfmtStep.Style.DROPBOX);
120112
}
@@ -131,13 +123,18 @@ public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfigur
131123
this.configurableStyle.configure(optionsConfiguration);
132124
}
133125

126+
private ConfigurableStyle style(KtfmtStep.Style style) {
127+
this.style = style;
128+
replaceStep(createStep());
129+
return configurableStyle;
130+
}
131+
134132
private FormatterStep createStep() {
135133
return KtfmtStep.create(version, provisioner(), style, options);
136134
}
137135

138136
public class ConfigurableStyle {
139-
140-
public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfiguration) {
137+
private void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfiguration) {
141138
KtfmtStep.KtfmtFormattingOptions ktfmtFormattingOptions = new KtfmtStep.KtfmtFormattingOptions();
142139
optionsConfiguration.accept(ktfmtFormattingOptions);
143140
options = ktfmtFormattingOptions;
@@ -147,26 +144,26 @@ public void configure(Consumer<KtfmtStep.KtfmtFormattingOptions> optionsConfigur
147144
}
148145

149146
public class KtlintConfig {
150-
151147
private final String version;
152-
@Nullable
153148
private FileSignature editorConfigPath;
154149
private Map<String, String> userData;
155150
private Map<String, Object> editorConfigOverride;
156151

157-
KtlintConfig(String version, Map<String, String> config,
152+
private KtlintConfig(
153+
String version,
154+
Map<String, String> userData,
158155
Map<String, Object> editorConfigOverride) throws IOException {
159156
Objects.requireNonNull(version);
160157
File defaultEditorConfig = getProject().getRootProject().file(".editorconfig");
161158
FileSignature editorConfigPath = defaultEditorConfig.exists() ? FileSignature.signAsList(defaultEditorConfig) : null;
162159
this.version = version;
163160
this.editorConfigPath = editorConfigPath;
164-
this.userData = config;
161+
this.userData = userData;
165162
this.editorConfigOverride = editorConfigOverride;
166163
addStep(createStep());
167164
}
168165

169-
public KtlintConfig setEditorConfigPath(Object editorConfigPath) throws IOException {
166+
public KtlintConfig setEditorConfigPath(@Nullable Object editorConfigPath) throws IOException {
170167
if (editorConfigPath == null) {
171168
this.editorConfigPath = null;
172169
} else {

0 commit comments

Comments
 (0)