Compile CaDiCaL with -DNDEBUG #8397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using CaDiCaL with CBMC showed substantially decreased performance between versions 1.8.0 and 1.9.0. This has become apparent with Kani, but also our THOROUGH tests changed from 7 minutes to just under 2 hours in CI. The culprit is
arminbiere/cadical@69e7cfb, which introduces expensive checks in
NDEBUG
blocks.