Skip to content

implement flattening for +/- for the range type #8396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

kroening
Copy link
Member

The flattening solver backend lowers the integer range type to bitvectors. This adds support for addition and subtraction for the range type via lowering to bitvector addition/subtraction.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The flattening solver backend lowers the integer range type to bitvectors.
This adds support for addition and subtraction for the range type via
lowering to bitvector addition/subtraction.
@kroening kroening marked this pull request as ready for review July 26, 2024 19:19
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.02%. Comparing base (bf58af8) to head (1a020c4).

Files Patch % Lines
src/solvers/flattening/boolbv_add_sub.cpp 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8396      +/-   ##
===========================================
- Coverage    78.02%   78.02%   -0.01%     
===========================================
  Files         1726     1726              
  Lines       189432   189442      +10     
  Branches     18465    18466       +1     
===========================================
+ Hits        147807   147808       +1     
- Misses       41625    41634       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 9dbbada into develop Jul 26, 2024
40 of 41 checks passed
@tautschnig tautschnig deleted the range-add-sub branch July 26, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants