Avoid confusing "__CPROVER_{r,w,rw}_ok is not declared" warning #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With 4b05d48 there no longer is a (pseudo-) forward declaration available, making the C front-end warn about this built-in function not being declared. As this is polymorphic, we shouldn't be type checking it as a function in the first place, and instead should give it separate treatment as we do with other polymorphic built-ins.
tautschnig
requested review from
kroening,
chris-ryder,
peterschrammel and
remi-delmas-3000
as code owners
Codecov ReportBase: 78.43% // Head: 78.50% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7560 +/- ##
===========================================
+ Coverage 78.43% 78.50% +0.07%
===========================================
Files 1670 1670
Lines 191671 191672 +1
===========================================
+ Hits 150331 150477 +146
+ Misses 41340 41195 -145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kroening
approved these changes
Feb 23, 2023
tautschnig
assigned
tautschnig and unassigned
kroening,
remi-delmas-3000 and
peterschrammel
1. Avoid `throw 0` 2. size_of_expr cannot fail at this point given all prior type checking. 3. Test all the failure handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 4b05d48 there no longer is a (pseudo-) forward declaration available, making the C front-end warn about this built-in function not being declared. As this is polymorphic, we shouldn't be type checking it as a function in the first place, and instead should give it separate treatment as we do with other polymorphic built-ins.