Skip to content

Remove internal symbols: keep all symbols used in contracts #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

In beb1353 we had chosen to only keep code-typed symbols, but indeed we also need to retain objects (only) referred to from contracts.

Also add debug-level status information of what symbols are being removed (which is information I have previously needed more than once in debugging, and it's also now the only actual use of the messaget that we already had in place).

Fixes: #7414

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig force-pushed the bugfixes/7414-contract-static branch 2 times, most recently from 25a3c04 to 035eccc Compare December 7, 2022 23:46
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 78.41% // Head: 78.41% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c4fdaf8) compared to base (206cf2a).
Patch coverage: 74.25% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7417      +/-   ##
===========================================
- Coverage    78.41%   78.41%   -0.01%     
===========================================
  Files         1659     1660       +1     
  Lines       190382   190423      +41     
===========================================
+ Hits        149280   149311      +31     
- Misses       41102    41112      +10     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/libcprover-cpp/api.h 100.00% <ø> (ø)
src/solvers/flattening/pointer_logic.cpp 95.06% <ø> (ø)
src/cprover/bv_pointers_wide.cpp 58.28% <26.66%> (+0.58%) ⬆️
src/libcprover-cpp/api.cpp 71.42% <63.15%> (-9.83%) ⬇️
unit/libcprover-cpp/api.cpp 72.41% <72.41%> (ø)
regression/libcprover-cpp/call_bmc.cpp 81.25% <100.00%> (+6.25%) ⬆️
src/ansi-c/c_typecheck_expr.cpp 75.78% <100.00%> (+0.02%) ⬆️
src/linking/remove_internal_symbols.cpp 100.00% <100.00%> (ø)
src/solvers/flattening/bv_pointers.cpp 86.28% <100.00%> (+0.06%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jimgrundy jimgrundy added aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Dec 12, 2022
In beb1353 we had chosen to only keep code-typed symbols, but indeed
we also need to retain objects (only) referred to from contracts.

Also add debug-level status information of what symbols are being
removed (which is information I have previously needed more than once in
debugging, and it's also now the only actual use of the messaget that we
already had in place).

Fixes: diffblue#7414
@tautschnig tautschnig force-pushed the bugfixes/7414-contract-static branch from 035eccc to c4fdaf8 Compare December 15, 2022 19:27
@tautschnig tautschnig assigned tautschnig and unassigned kroening Dec 15, 2022
@tautschnig tautschnig merged commit 6d2e501 into diffblue:develop Dec 15, 2022
@tautschnig tautschnig deleted the bugfixes/7414-contract-static branch December 15, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users bugfix Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goto-cc --export-file-local-symbols does not export symbols that are only used in contracts.
3 participants