-
Notifications
You must be signed in to change notification settings - Fork 277
Make verbosity of symtab2gb configurable #7240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make verbosity of symtab2gb configurable #7240
Conversation
Codecov ReportBase: 78.38% // Head: 78.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7240 +/- ##
========================================
Coverage 78.38% 78.38%
========================================
Files 1647 1647
Lines 190362 190361 -1
========================================
+ Hits 149213 149218 +5
+ Misses 41149 41143 -6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -17,6 +17,7 @@ Author: Diffblue Ltd. | |||
|
|||
#define SYMTAB2GB_OPTIONS \ | |||
"(" SYMTAB2GB_OUT_FILE_OPT "):" \ | |||
"(verbosity):" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick - Missing trailing \
which should be there for merge-conflict / diff-minimisation related reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem here is that clang-format removes that one, so one has to switch off clang-format for that bit of code, which has other downsides...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(And I haven't found an option to teach clang-format otherwise.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We turn off clang-format in the other *_parse_options.h
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was actually also the case here, my bad. I've added the backslash.
2c52706
to
311daf4
Compare
311daf4
to
c82cfd7
Compare
Do not produce debug output (as goto_convert might do, e.g., reporting on destructor code being produced) by default.
c82cfd7
to
afea0d3
Compare
Do not produce debug output (as goto_convert might do, e.g., reporting on destructor code being produced) by default.