Skip to content

Make verbosity of symtab2gb configurable #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Do not produce debug output (as goto_convert might do, e.g., reporting on destructor code being produced) by default.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 78.38% // Head: 78.38% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (afea0d3) compared to base (9100d23).
Patch coverage: 85.07% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7240   +/-   ##
========================================
  Coverage    78.38%   78.38%           
========================================
  Files         1647     1647           
  Lines       190362   190361    -1     
========================================
+ Hits        149213   149218    +5     
+ Misses       41149    41143    -6     
Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 67.66% <ø> (ø)
src/goto-instrument/race_check.cpp 0.00% <0.00%> (ø)
src/goto-symex/goto_symex.cpp 98.64% <ø> (ø)
src/goto-symex/goto_symex.h 86.66% <ø> (ø)
src/symtab2gb/symtab2gb_parse_options.h 100.00% <ø> (ø)
src/util/pointer_predicates.h 100.00% <ø> (ø)
src/goto-symex/auto_objects.cpp 26.31% <16.66%> (+2.50%) ⬆️
src/goto-programs/initialize_goto_model.cpp 89.24% <83.33%> (+0.11%) ⬆️
src/goto-symex/symex_builtin_functions.cpp 93.12% <89.28%> (-0.23%) ⬇️
src/ansi-c/ansi_c_entry_point.cpp 89.80% <100.00%> (+0.22%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -17,6 +17,7 @@ Author: Diffblue Ltd.

#define SYMTAB2GB_OPTIONS \
"(" SYMTAB2GB_OUT_FILE_OPT "):" \
"(verbosity):"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick - Missing trailing \ which should be there for merge-conflict / diff-minimisation related reasons.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that clang-format removes that one, so one has to switch off clang-format for that bit of code, which has other downsides...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(And I haven't found an option to teach clang-format otherwise.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We turn off clang-format in the other *_parse_options.h

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was actually also the case here, my bad. I've added the backslash.

@tautschnig tautschnig added the Kani Bugs or features of importance to Kani Rust Verifier label Nov 13, 2022
@tautschnig tautschnig force-pushed the cleanup/symtab2gb-verbosity branch from 2c52706 to 311daf4 Compare November 20, 2022 21:29
@feliperodri feliperodri added the aws Bugs or features of importance to AWS CBMC users label Nov 28, 2022
@tautschnig tautschnig force-pushed the cleanup/symtab2gb-verbosity branch from 311daf4 to c82cfd7 Compare December 1, 2022 17:23
Do not produce debug output (as goto_convert might do, e.g., reporting
on destructor code being produced) by default.
@tautschnig tautschnig force-pushed the cleanup/symtab2gb-verbosity branch from c82cfd7 to afea0d3 Compare December 1, 2022 17:29
@tautschnig tautschnig merged commit eb0472e into diffblue:develop Dec 1, 2022
@tautschnig tautschnig deleted the cleanup/symtab2gb-verbosity branch December 1, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants