Skip to content

Goto-harness, memory analyzer: print version, help to stdout #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

tautschnig
Copy link
Collaborator

Using a stream that possibly isn't even configured just yet (for
command-line parsing is required to do so) makes it impossible to
produce visible output.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Using a stream that possibly isn't even configured just yet (for
command-line parsing is required to do so) makes it impossible to
produce visible output.
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #6934 (f7c81f2) into develop (06350a0) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #6934      +/-   ##
===========================================
+ Coverage    77.79%   77.81%   +0.01%     
===========================================
  Files         1568     1568              
  Lines       180317   180288      -29     
===========================================
  Hits        140285   140285              
+ Misses       40032    40003      -29     
Impacted Files Coverage Δ
jbmc/src/java_bytecode/java_bytecode_language.h 76.47% <ø> (ø)
jbmc/src/jbmc/jbmc_parse_options.cpp 76.06% <0.00%> (-0.19%) ⬇️
src/cbmc/cbmc_parse_options.cpp 80.10% <ø> (ø)
src/goto-harness/goto_harness_parse_options.cpp 78.09% <0.00%> (+9.76%) ⬆️
.../memory-analyzer/memory_analyzer_parse_options.cpp 65.78% <0.00%> (+10.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a914ead...f7c81f2. Read the comment docs.

The preceding help entry was missing a newline, and the option itself
did not make clear that an argument was required.
@tautschnig
Copy link
Collaborator Author

@chris-ryder Just a ping as I'll need your review here.

Copy link

@chris-ryder chris-ryder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with apologies for the tardiness!

@tautschnig tautschnig merged commit e104827 into diffblue:develop Jul 6, 2022
@tautschnig tautschnig deleted the cleanup/help-stdout branch July 6, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants