Skip to content

Value sets: fix byte extracts from structs #6107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2021

Conversation

tautschnig
Copy link
Collaborator

Pointers may be contained in any member that's included in the byte
range being extracted, not just the one right at the offset that the
byte extract starts from.

Co-Authored-By: Petr Bauch petr.bauch@gmail.com

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Pointers may be contained in any member that's included in the byte
range being extracted, not just the one right at the offset that the
byte extract starts from.

Co-Authored-By: Petr Bauch <petr.bauch@gmail.com>
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #6107 (6ac8ebb) into develop (4c14789) will increase coverage by 0.08%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6107      +/-   ##
===========================================
+ Coverage    74.52%   74.60%   +0.08%     
===========================================
  Files         1447     1447              
  Lines       157808   157825      +17     
===========================================
+ Hits        117610   117752     +142     
+ Misses       40198    40073     -125     
Impacted Files Coverage Δ
src/pointer-analysis/value_set.cpp 81.14% <93.75%> (-1.48%) ⬇️
src/solvers/flattening/boolbv_index.cpp 89.72% <100.00%> (+10.77%) ⬆️
src/solvers/smt2/smt2_conv.cpp 60.63% <0.00%> (+0.22%) ⬆️
src/solvers/lowering/byte_operators.cpp 92.16% <0.00%> (+0.36%) ⬆️
src/ansi-c/c_typecast.cpp 79.00% <0.00%> (+0.55%) ⬆️
src/util/pointer_offset_size.cpp 86.79% <0.00%> (+1.07%) ⬆️
src/solvers/flattening/boolbv_byte_extract.cpp 82.27% <0.00%> (+12.65%) ⬆️
src/solvers/floatbv/float_bv.cpp 88.33% <0.00%> (+14.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f30441...6ac8ebb. Read the comment docs.

@tautschnig tautschnig self-assigned this May 11, 2021
Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NlightNFotis NlightNFotis merged commit 8e651e4 into diffblue:develop May 12, 2021
@tautschnig tautschnig deleted the value-set-byte_extract branch May 12, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants