Skip to content

Make test identifier_names_illegal_characters work on Windows #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

GCC built-ins are only available with a GCC-like front-end, and thus
need to be wrapped in #ifdef GNUC. While at it, also reduce
duplicate infrastructure by moving the test to the goto-instrument
folder.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

GCC built-ins are only available with a GCC-like front-end, and thus
need to be wrapped in #ifdef __GNUC__. While at it, also reduce
duplicate infrastructure by moving the test to the goto-instrument
folder.
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #5571 (d97fe4c) into develop (aa069d3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5571   +/-   ##
========================================
  Coverage    69.31%   69.31%           
========================================
  Files         1241     1241           
  Lines       100407   100407           
========================================
+ Hits         69596    69601    +5     
+ Misses       30811    30806    -5     
Flag Coverage Δ
cproversmt2 43.08% <ø> (ø)
regression 66.22% <ø> (+<0.01%) ⬆️
unit 32.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/goto-instrument/goto_program2code.cpp 66.40% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa069d3...d97fe4c. Read the comment docs.

@tautschnig tautschnig merged commit 53750fa into diffblue:develop Nov 13, 2020
@tautschnig tautschnig deleted the fix-identifier_names_illegal_characters-test branch November 13, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants