Remove deprecated side_effect_expr*t constructors

[tautschnig]

These were deprecated in 2018 and the remaining in-tree uses are now
fixed/removed.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #5554 (1282ac3) into develop (27f2a8a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #5554      +/-   ##
===========================================
- Coverage    68.53%   68.53%   -0.01%     
===========================================
  Files         1187     1187              
  Lines        98263    98262       -1     
===========================================
- Hits         67347    67346       -1     
  Misses       30916    30916              

Flag	Coverage Δ
cproversmt2	43.09% <ø> (ø)
regression	65.71% <100.00%> (-0.01%)	⬇️
unit	32.26% <60.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/util/std_code.h	93.06% <ø> (-0.04%)	⬇️
jbmc/src/java_bytecode/code_with_references.cpp	80.00% <100.00%> (ø)
jbmc/src/java_bytecode/java_entry_point.cpp	87.92% <100.00%> (+0.05%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f2a8a...1282ac3. Read the comment docs.

[tautschnig]

I'd like to note that the reduced coverage of std_code.h seems to be an artefact of removing code in this file.

[martin-cs]

Looks good. If there are any at Diffblue who can comment on jbmc it might avoid breaking things.

[peterschrammel]

lgtm