add file_exists(path) #5215
Merged
add file_exists(path) #5215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
This offers the obvious wrapper around the OS-specific access() function, to be used until we switch to C++17.
kroening
force-pushed
the
file-exists
branch
2 times, most recently
from
aac2283 to
ecba483
Compare
Added file_remove, the obvious wrapper around the OS-specific unlink. This will be replaced by std::filesystem::remove once we have C++17.
hannes-steffenhagen-diffblue
approved these changes
Jan 28, 2020
peterschrammel
approved these changes
Feb 1, 2020
| @@ -124,8 +125,8 @@ int hybrid_binary( | |||
| } | |||
|
|
|||
| // delete the goto binary | |||
| int remove_result = remove(goto_binary_file.c_str()); | |||
| if(remove_result != 0) | |||
| bool remove_result = file_remove(goto_binary_file); | |||
| @@ -64,8 +65,8 @@ int hybrid_binary( | |||
| } | |||
|
|
|||
| // delete the goto binary | |||
| int remove_result = remove(goto_binary_file.c_str()); | |||
| if(remove_result != 0) | |||
| bool remove_result = file_remove(goto_binary_file); | |||
chrisr-diffblue
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers the obvious wrapper around the OS-specific
access()andremove/unlinkfunctions, to be used until we switch to C++17.