offer .lhs() and .rhs() for all binary expressions #5044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is follow up from #5025. A clear desire is visible to use .lhs() and .rhs() on binary expressions, say minus_exprt.
kroening
requested review from
chrisr-diffblue,
danpoe,
martin-cs,
owen-mc-diffblue,
peterschrammel,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
thk123
approved these changes
Aug 21, 2019
| { | ||
| return exprt::op1(); | ||
| } | ||
|
|
||
| // make op0 and op1 public | ||
| using exprt::op0; |
There was a problem hiding this comment.
⛏️ These are probably not required any more right? Should be marked as deprecated at least
There was a problem hiding this comment.
This is coming (they can only be marked deprecated once all uses are removed, or CI will fail).
smowton
approved these changes
Aug 21, 2019
allredj
reviewed
Aug 21, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: dfb9421).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124106593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up from #5025. A clear desire is visible to use
.lhs()and.rhs()on binary expressions, sayminus_exprt.