Skip to content

Make sure pragmas propagate to all source locations #4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Make sure pragmas propagate to all source locations #4666

merged 1 commit into from
May 22, 2019

Conversation

tautschnig
Copy link
Collaborator

The previous fix would still fail for assignments with side effects as
those expressions are broken up, and the inner assignment would not have
had the pragma annotated. Instead, store the pragmas in the parser's
source location, which is copied to all expressions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

allredj
allredj reviewed May 16, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 9e0af23).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112150720

@tautschnig tautschnig mentioned this pull request May 17, 2019
Merged
3 tasks
danielsn added a commit to danielsn/aws-c-common that referenced this pull request May 20, 2019
@danielsn
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
d966c70
@danielsn danielsn mentioned this pull request May 20, 2019
Merged
@kroening kroening assigned peterschrammel and unassigned kroening May 21, 2019
@tautschnig
Make sure pragmas propagate to all source locations
1b7b347 
The previous fix would still fail for assignments with side effects as
those expressions are broken up, and the inner assignment would not have
had the pragma annotated. Instead, store the pragmas in the parser's
source location, which is copied to all expressions.
smowton
smowton approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell; this is still quite sparsely tested though

@tautschnig tautschnig merged commit 1d021aa into diffblue:develop May 22, 2019
@tautschnig tautschnig deleted the suppression-fix branch May 22, 2019 10:44
danielsn added a commit to danielsn/aws-c-common that referenced this pull request May 23, 2019
@danielsn
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
98a1220
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request May 31, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
db1ad44
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request May 31, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
0d63d39
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request Jun 5, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
dc3d690
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request Jun 6, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
4aa4e8c
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request Jun 10, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
b7b0265
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request Jun 20, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
09addea
feliperodri pushed a commit to danielsn/aws-c-common that referenced this pull request Jun 20, 2019
@danielsn @feliperodri
turn on overflow checking, will work once diffblue/cbmc#4666 is merged
8794fdf
danielsn added a commit to awslabs/aws-c-common that referenced this pull request Jun 21, 2019
@danielsn
Hash table predefined hashes (#364)
56bb816 
* aws_hash_ptr + aws_hash_c_string

* suppress undefined checks

* check inputs to hash functions

* turn on overflow checking, will work once diffblue/cbmc#4666 is merged

* whitespace change to retrigger ci

* Update bounds to aws_hash_c_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update bounds to aws_hash_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update cbmc-batch.yaml files

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Disable pointers check on parts of hashlittle2

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update bounds in aws_hash_c_string and aws_hash_string proofs

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Improve documentation on the aws_hash_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* PR comments

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update cbmc-batch.yaml files

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* PR comments

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update proofs bounds

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Guard CPROVER pragmas with CBMC macro

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update postconditions

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
dislogical pushed a commit to awslabs/aws-c-common that referenced this pull request Jun 21, 2019
@feliperodri @dislogical
Adds proof harnesses for aws_hash_*_ignore_case functions (#403)
43c89b1 
* aws_hash_ptr + aws_hash_c_string

* suppress undefined checks

* check inputs to hash functions

* turn on overflow checking, will work once diffblue/cbmc#4666 is merged

* whitespace change to retrigger ci

* Update bounds to aws_hash_c_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update bounds to aws_hash_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update cbmc-batch.yaml files

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Disable pointers check on parts of hashlittle2

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update bounds in aws_hash_c_string and aws_hash_string proofs

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Improve documentation on the aws_hash_string proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* PR comments

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update cbmc-batch.yaml files

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* PR comments

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update proofs bounds

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Guard CPROVER pragmas with CBMC macro

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update postconditions

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Adds a proof harness for the aws_hash_array_ignore_case function

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Adds a precondition to aws_hash_array_ignore_case function

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Adds a proof harness for aws_hash_byte_cursor_ptr_ignore_case function

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Update the bound of aws_hash_array_ignore_case proof

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* PR comments

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Guard CPROVER pragmas with CBMC

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>

* Remove meaningless const qualifiers

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@kroening kroening kroening approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@danpoe danpoe Awaiting requested review from danpoe

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@owen-mc-diffblue owen-mc-diffblue Awaiting requested review from owen-mc-diffblue

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@thk123 thk123 Awaiting requested review from thk123

Assignees

@smowton smowton

@peterschrammel peterschrammel

@chrisr-diffblue chrisr-diffblue

Labels
bugfix C Front End
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tautschnig @smowton @kroening @allredj @peterschrammel @chrisr-diffblue