Skip to content

Add the deprecation date to each deprecated entity [blocks: #3768, #4248, #4368, #4371] #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2019

Conversation

tautschnig
Copy link
Collaborator

This makes the date of deprecation visible in warning messages and also
makes tracking much easier: git grep DEPRECATED or any code review will
yield immediate insight on how long an entity has been deprecated
already.

The date is taken from the commit that first marked the entity as
deprecated.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
Copy link
Member

clang-format isn't helping...

@kroening kroening removed their assignment Mar 23, 2019
@tautschnig
Copy link
Collaborator Author

clang-format isn't helping...

Ack, but I figured we should rather remove many of them as soon as possible rather than bothering much with clang-format off or shortening the message.

@tautschnig
Copy link
Collaborator Author

FWIW: once this PR and (an agreed variant of) #4424 are merged I'd like to do a cleanup of all code that has gone past the six-months mark.

@tautschnig tautschnig force-pushed the deprecated-dates branch 3 times, most recently from b6ecfb6 to 3222d89 Compare March 23, 2019 20:16
@tautschnig tautschnig changed the title Add the deprecation date to each deprecated entity Add the deprecation date to each deprecated entity [blocks: #3768, #4368, #4371] Mar 23, 2019
@tautschnig tautschnig changed the title Add the deprecation date to each deprecated entity [blocks: #3768, #4368, #4371] Add the deprecation date to each deprecated entity [blocks: #3768, #4248, #4368, #4371] Mar 23, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 3222d89).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105555269

@tautschnig tautschnig mentioned this pull request Mar 23, 2019
3 tasks
This makes the date of deprecation visible in warning messages and also
makes tracking much easier: git grep DEPRECATED or any code review will
yield immediate insight on how long an entity has been deprecated
already.

The date is taken from the commit that first marked the entity as
deprecated.
@tautschnig tautschnig merged commit 6d0177b into diffblue:develop Mar 23, 2019
@tautschnig tautschnig deleted the deprecated-dates branch March 23, 2019 23:13
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e70dcf2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105558661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants