-
Notifications
You must be signed in to change notification settings - Fork 277
Add the deprecation date to each deprecated entity [blocks: #3768, #4248, #4368, #4371] #4423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clang-format isn't helping... |
Ack, but I figured we should rather remove many of them as soon as possible rather than bothering much with |
FWIW: once this PR and (an agreed variant of) #4424 are merged I'd like to do a cleanup of all code that has gone past the six-months mark. |
b6ecfb6
to
3222d89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3222d89).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105555269
This makes the date of deprecation visible in warning messages and also makes tracking much easier: git grep DEPRECATED or any code review will yield immediate insight on how long an entity has been deprecated already. The date is taken from the commit that first marked the entity as deprecated.
3222d89
to
e70dcf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: e70dcf2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/105558661
This makes the date of deprecation visible in warning messages and also
makes tracking much easier: git grep DEPRECATED or any code review will
yield immediate insight on how long an entity has been deprecated
already.
The date is taken from the commit that first marked the entity as
deprecated.