Skip to content

Commit 9ae6596

Browse files
committed
cpplint strictly requires Python 2
Using Python 3 (as is the default in Ubuntu 20.04) requires merging changes from https://github.com/cpplint/cpplint, which is a larger undertaking.
1 parent 737ff9f commit 9ae6596

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/pull-request-checks.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ jobs:
352352
run: ./.github/workflows/pull-request-check-clang-format.sh
353353

354354
check-cpplint:
355-
runs-on: ubuntu-20.04
355+
runs-on: ubuntu-18.04
356356
steps:
357357
- uses: actions/checkout@v2
358358
with:
@@ -364,7 +364,8 @@ jobs:
364364
# user input
365365
DEBIAN_FRONTEND: noninteractive
366366
run: |
367-
pip install unidiff
367+
sudo apt-get update
368+
sudo apt-get install --no-install-recommends -yq python-unidiff
368369
- name: Check updated lines of code meet linting standards
369370
env:
370371
BASE_BRANCH: ${{ github.base_ref }}

scripts/cpplint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#!/usr/bin/env python
1+
#!/usr/bin/env python2
22
# -*- coding: utf-8 -*-
33
#
44
# Copyright (c) 2009 Google Inc. All rights reserved.

0 commit comments

Comments
 (0)