Adjust spacing, line breaks to coding guidelines

Also added to comments to for loops that do not include increments in
the loop header.

Author: tautschnig

src/analyses/cfg_dominators.h

@@ -221,8 +221,10 @@ void cfg_dominators_templatet<P, T, post_dom>::output(std::ostream &out) const
       out << n << " post-dominated by ";
     else
       out << n << " dominated by ";
-    for(typename target_sett::const_iterator d_it=node.second.dominators.begin();
-        d_it!=node.second.dominators.end();)
+    for(typename target_sett::const_iterator
+        d_it=node.second.dominators.begin();
+        d_it!=node.second.dominators.end();
+       ) // no d_it++
     {
       out << (*d_it)->location_number;
       if (++d_it!=node.second.dominators.end())

src/analyses/constant_propagator.cpp

@@ -398,7 +398,7 @@ bool constant_propagator_domaint::valuest::merge(const valuest &src)
   for(replace_symbolt::expr_mapt::const_iterator
         it=replace_const.expr_map.begin();
       it!=replace_const.expr_map.end();
-      )
+      ) // no it++
   {
     if(src.replace_const.expr_map.find(it->first) ==
        src.replace_const.expr_map.end())
@@ -459,19 +459,19 @@ bool constant_propagator_domaint::valuest::meet(const valuest &src)
     replace_symbolt::expr_mapt::iterator c_it=
       replace_const.expr_map.find(src_replace_pair.first);
 
-    if(c_it != replace_const.expr_map.end())
+    if(c_it!=replace_const.expr_map.end())
     {
       if(c_it->second!=src_replace_pair.second)
       {
         set_to_bottom();
-        changed = true;
+        changed=true;
         break;
       }
     }
     else
     {
       set_to(src_replace_pair.first, src_replace_pair.second);
-      changed = true;
+      changed=true;
     }
   }
 

src/analyses/custom_bitvector_analysis.cpp

@@ -678,7 +678,7 @@ void custom_bitvector_domaint::erase_blank_vectors(bitst &bits)
 {
   for(bitst::iterator a_it=bits.begin();
       a_it!=bits.end();
-      )
+     ) // no a_it++
   {
     if(a_it->second==0)
       a_it=bits.erase(a_it);