Adding tests for simplify function pointer removal

The variable sensitivity domain should be able to simplify the if
statements produced by the function pointer removal, even in the cases
where the pointer isn't definitely const.

Author: thk123

regression/goto-analyzer/simplify-fp-const-lost/main.c

@@ -0,0 +1,35 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  const void_fp fp = f2;
+
+  // Warning: this loses const-ness of f2
+  void_fp * p2fp = (void_fp*)&fp;
+  *p2fp = &f4;
+
+  fp();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-const-lost/test.desc

@@ -0,0 +1,12 @@
+CORE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 9
+^Unmodified:  .* goto: 9
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step

regression/goto-analyzer/simplify-fp-dynamic-array-fp/main.c

@@ -0,0 +1,36 @@
+#include <stdio.h>
+#include <stdlib.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  void_fp * const fp_tbl= malloc(sizeof(void_fp) * 3);
+  fp_tbl[0]=f2;
+  fp_tbl[1]=f3;
+  fp_tbl[2]=f4;
+
+  const void_fp fp = fp_tbl[1];
+  fp();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-dynamic-array-fp/test.desc

@@ -0,0 +1,12 @@
+FUTURE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 8
+^Unmodified:  .* goto: 10
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step. This requires supporting tracking arrays assigned dynamically

regression/goto-analyzer/simplify-fp-fp-param/main.c

@@ -0,0 +1,29 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(void_fp fp)
+{
+  fp();
+}
+
+int main(int argc, char** argv)
+{
+
+  func(&f2);
+  return 0;
+}

regression/goto-analyzer/simplify-fp-fp-param/test.desc

@@ -0,0 +1,12 @@
+CORE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 7
+^Unmodified:  .* goto: 11
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step.

regression/goto-analyzer/simplify-fp-modified-array-pointer-fp/main.c

@@ -0,0 +1,41 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  const void_fp start_fp = f2;
+  const void_fp * const fp_tbl[] = { &start_fp, &start_fp, &start_fp };
+
+  // warning: loses const
+  void_fp * arr_ptr=fp_tbl[0];
+  (*arr_ptr) = f5;
+  arr_ptr++;
+  (*arr_ptr) = f5;
+
+  const void_fp * const fp = fp_tbl[1];
+
+
+  (*fp)();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-modified-array-pointer-fp/test.desc

@@ -0,0 +1,12 @@
+FUTURE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 8
+^Unmodified:  .* goto: 10
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step

regression/goto-analyzer/simplify-fp-modified-array/main.c

@@ -0,0 +1,39 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  const void_fp fp_tbl[] = {f2, f3 ,f4};
+
+  // warning: loses const
+  void_fp * arr_ptr=&fp_tbl[0];
+  (*arr_ptr) = f5;
+  arr_ptr++;
+  (*arr_ptr) = f5;
+
+  const void_fp fp = &fp_tbl[1];
+
+  fp();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-modified-array/test.desc

@@ -0,0 +1,12 @@
+FUTURE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 8
+^Unmodified:  .* goto: 10
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step

regression/goto-analyzer/simplify-fp-non-const-pointer/main.c

@@ -0,0 +1,31 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  void_fp fp = f2;
+  fp = f3;
+  fp();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-non-const-pointer/test.desc

@@ -0,0 +1,12 @@
+CORE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 8
+^Unmodified:  .* goto: 10
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step

regression/goto-analyzer/simplify-fp-pointer-fp/main.c

@@ -0,0 +1,36 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func()
+{
+  const void_fp fp = f3;
+  const void_fp fp2 = f4;
+  const void_fp* p2fp = &fp;
+
+  // legal:
+  p2fp = &fp2;
+  const void_fp final_fp=*p2fp;
+  final_fp();
+}
+
+int main()
+{
+  func();
+
+  return 0;
+}

regression/goto-analyzer/simplify-fp-pointer-fp/test.desc

@@ -0,0 +1,12 @@
+CORE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 9
+^Unmodified:  .* goto: 9
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step

regression/goto-analyzer/simplify-fp-variable-array/main.c

@@ -0,0 +1,31 @@
+#include <stdio.h>
+
+void f1 (void) { printf("%i\n", 1); }
+void f2 (void) { printf("%i\n", 2); }
+void f3 (void) { printf("%i\n", 3); }
+void f4 (void) { printf("%i\n", 4); }
+void f5 (void) { printf("%i\n", 5); }
+void f6 (void) { printf("%i\n", 6); }
+void f7 (void) { printf("%i\n", 7); }
+void f8 (void) { printf("%i\n", 8); }
+void f9 (void) { printf("%i\n", 9); }
+
+typedef void(*void_fp)(void);
+
+// There is a basic check that excludes all functions that aren't used anywhere
+// This ensures that check can't work in this example
+const void_fp fp_all[] = {f1, f2 ,f3, f4, f5 ,f6, f7, f8, f9};
+
+void func(int i, int j)
+{
+  const void_fp fp_tbl[] = {fp_all[i*2], fp_all[j+1]};
+  const void_fp fp = fp_tbl[1];
+  fp();
+}
+
+int main(int argc, char** argv)
+{
+
+  func(argc,0);
+  return 0;
+}

regression/goto-analyzer/simplify-fp-variable-array/test.desc

@@ -0,0 +1,13 @@
+CORE
+main.c
+--simplify out_simplified.gb --variable --arrays --structs --pointers
+^Simplified:  .* goto: 3
+^Unmodified:  .* goto: 15
+^SIGNAL=0$
+^EXIT=0$
+--
+^warning: ignoring
+--
+Check the GOTOs generated by the function pointer removal are removed by the
+simplify step. The number fo removed goto statements doesn't seem correct,
+but inspecting the output using show-goto-functions reveals the right program.