bv_utilst::sign_extension, zero_extension and zeros can be static

kroening · kroening · commit 57a52d38d5c2 · 2022-04-29T12:15:58.000+01:00
These methods do not use any state of bv_utilst and can therefore be static.
diff --git a/src/solvers/flattening/bv_utils.h b/src/solvers/flattening/bv_utils.h
@@ -179,17 +179,17 @@ class bv_utilst
   static bvt
   extension(const bvt &bv, std::size_t new_size, representationt rep);
 
-  bvt sign_extension(const bvt &bv, std::size_t new_size)
+  static bvt sign_extension(const bvt &bv, std::size_t new_size)
   {
     return extension(bv, new_size, representationt::SIGNED);
   }
 
-  bvt zero_extension(const bvt &bv, std::size_t new_size)
+  static bvt zero_extension(const bvt &bv, std::size_t new_size)
   {
     return extension(bv, new_size, representationt::UNSIGNED);
   }
 
-  bvt zeros(std::size_t new_size) const
+  static bvt zeros(std::size_t new_size)
   {
     bvt result;
     result.resize(new_size, const_literal(false));

Original file line number	Diff line number	Diff line change
`@@ -179,17 +179,17 @@ class bv_utilst`
`179`	`179`	`static bvt`
`180`	`180`	`extension(const bvt &bv, std::size_t new_size, representationt rep);`
`181`	`181`
`182`		`- bvt sign_extension(const bvt &bv, std::size_t new_size)`
	`182`	`+ static bvt sign_extension(const bvt &bv, std::size_t new_size)`
`183`	`183`	`{`
`184`	`184`	`return extension(bv, new_size, representationt::SIGNED);`
`185`	`185`	`}`
`186`	`186`
`187`		`- bvt zero_extension(const bvt &bv, std::size_t new_size)`
	`187`	`+ static bvt zero_extension(const bvt &bv, std::size_t new_size)`
`188`	`188`	`{`
`189`	`189`	`return extension(bv, new_size, representationt::UNSIGNED);`
`190`	`190`	`}`
`191`	`191`
`192`		`- bvt zeros(std::size_t new_size) const`
	`192`	`+ static bvt zeros(std::size_t new_size)`
`193`	`193`	`{`
`194`	`194`	`bvt result;`
`195`	`195`	`result.resize(new_size, const_literal(false));`