move goto_functionst::validate into .cpp file

The function is large, and thus, this improves compile times.

Author: Daniel Kroening

src/goto-programs/goto_functions.cpp

@@ -97,3 +97,45 @@ std::vector<goto_functionst::function_mapt::iterator> goto_functionst::sorted()
 
   return result;
 }
+
+void goto_functionst::validate(const namespacet &ns, const validation_modet vm)
+  const
+{
+  for(const auto &entry : function_map)
+  {
+    const goto_functiont &goto_function = entry.second;
+    const auto &function_name = entry.first;
+    const symbolt &function_symbol = ns.lookup(function_name);
+    const code_typet::parameterst &parameters =
+      to_code_type(function_symbol.type).parameters();
+
+    DATA_CHECK(
+      vm,
+      goto_function.type == ns.lookup(function_name).type,
+      id2string(function_name) + " type inconsistency\ngoto program type: " +
+        goto_function.type.id_string() +
+        "\nsymbol table type: " + ns.lookup(function_name).type.id_string());
+
+    DATA_CHECK(
+      vm,
+      goto_function.parameter_identifiers.size() == parameters.size(),
+      id2string(function_name) + " parameter count inconsistency\n" +
+        "goto program: " +
+        std::to_string(goto_function.parameter_identifiers.size()) +
+        "\nsymbol table: " + std::to_string(parameters.size()));
+
+    auto it = goto_function.parameter_identifiers.begin();
+    for(const auto &parameter : parameters)
+    {
+      DATA_CHECK(
+        vm,
+        it->empty() || ns.lookup(*it).type == parameter.type(),
+        id2string(function_name) + " parameter type inconsistency\n" +
+          "goto program: " + ns.lookup(*it).type.id_string() +
+          "\nsymbol table: " + parameter.type().id_string());
+      ++it;
+    }
+
+    goto_function.validate(ns, vm);
+  }
+}

src/goto-programs/goto_functions.h

@@ -111,46 +111,7 @@ class goto_functionst
   ///
   /// The validation mode indicates whether well-formedness check failures are
   /// reported via DATA_INVARIANT violations or exceptions.
-  void validate(const namespacet &ns, const validation_modet vm) const
-  {
-    for(const auto &entry : function_map)
-    {
-      const goto_functiont &goto_function = entry.second;
-      const auto &function_name = entry.first;
-      const symbolt &function_symbol = ns.lookup(function_name);
-      const code_typet::parameterst &parameters =
-        to_code_type(function_symbol.type).parameters();
-
-      DATA_CHECK(
-        vm,
-        goto_function.type == ns.lookup(function_name).type,
-        id2string(function_name) + " type inconsistency\ngoto program type: " +
-          goto_function.type.id_string() +
-          "\nsymbol table type: " + ns.lookup(function_name).type.id_string());
-
-      DATA_CHECK(
-        vm,
-        goto_function.parameter_identifiers.size() == parameters.size(),
-        id2string(function_name) + " parameter count inconsistency\n" +
-          "goto program: " +
-          std::to_string(goto_function.parameter_identifiers.size()) +
-          "\nsymbol table: " + std::to_string(parameters.size()));
-
-      auto it = goto_function.parameter_identifiers.begin();
-      for(const auto &parameter : parameters)
-      {
-        DATA_CHECK(
-          vm,
-          it->empty() || ns.lookup(*it).type == parameter.type(),
-          id2string(function_name) + " parameter type inconsistency\n" +
-            "goto program: " + ns.lookup(*it).type.id_string() +
-            "\nsymbol table: " + parameter.type().id_string());
-        ++it;
-      }
-
-      goto_function.validate(ns, vm);
-    }
-  }
+  void validate(const namespacet &, validation_modet) const;
 };
 
 #define Forall_goto_functions(it, functions) \