avoid access to instructiont::code

Author: Daniel Kroening

src/goto-symex/build_goto_trace.cpp

@@ -161,7 +161,7 @@ static void update_internal_field(
     // "__CPROVER_*" function calls in __CPROVER_start are already marked as
     // internal. Don't mark any other function calls (i.e. "main"), function
     // arguments or any other parts of a code_function_callt as internal.
-    if(SSA_step.source.pc->code.get_statement()!=ID_function_call)
+    if(!SSA_step.is_function_call())
       goto_trace_step.internal=true;
   }
 }

src/goto-symex/memory_model_tso.cpp

@@ -106,7 +106,7 @@ void memory_model_tsot::program_order(
 
         if((*e_it2)->is_memory_barrier())
         {
-          const codet &code = (*e_it2)->source.pc->code;
+          const codet &code = (*e_it2)->source.pc->get_other();
 
           if((*e_it)->is_shared_read() &&
              !code.get_bool(ID_RRfence) &&

src/goto-symex/symex_goto.cpp

@@ -122,8 +122,7 @@ void goto_symext::symex_goto(statet &state)
   {
     DATA_INVARIANT(
       instruction.targets.size() > 0,
-      "Instruction is an unconditional goto with no target: " +
-        instruction.code.pretty());
+      "Instruction is an unconditional goto with no target");
     symex_transition(state, instruction.get_target(), true);
     return;
   }