avoid exprt::op0, exprt::op1, exprt::op2

Author: Daniel Kroening

src/analyses/constant_propagator.cpp

@@ -631,7 +631,8 @@ void constant_propagator_ait::replace(
       d.partial_evaluate(rhs, ns);
 
       if(rhs.id()==ID_constant)
-        rhs.add_source_location()=it->code.op0().source_location();
+        rhs.add_source_location() =
+          to_code_assign(it->code).lhs().source_location();
     }
     else if(it->is_function_call())
     {

src/analyses/escape_analysis.cpp

@@ -142,7 +142,7 @@ void escape_domaint::get_rhs_aliases(
   }
   else if(rhs.id()==ID_address_of)
   {
-    get_rhs_aliases_address_of(to_address_of_expr(rhs).op0(), alias_set);
+    get_rhs_aliases_address_of(to_address_of_expr(rhs).op(), alias_set);
   }
 }
 

src/analyses/flow_insensitive_analysis.cpp

@@ -317,24 +317,15 @@ bool flow_insensitive_analysis_baset::do_function_call_rec(
   }
   else if(function.id()==ID_if)
   {
-    if(function.operands().size()!=3)
-      throw "if takes three arguments";
+    const auto &if_expr = to_if_expr(function);
 
-    new_data =
-      do_function_call_rec(
-        l_call,
-        function.op1(),
-        arguments,
-        state,
-        goto_functions);
+    new_data = do_function_call_rec(
+      l_call, if_expr.true_case(), arguments, state, goto_functions);
 
     new_data =
       do_function_call_rec(
-        l_call,
-        function.op2(),
-        arguments,
-        state,
-        goto_functions) || new_data;
+        l_call, if_expr.false_case(), arguments, state, goto_functions) ||
+      new_data;
   }
   else if(function.id()==ID_dereference)
   {

src/analyses/global_may_alias.cpp

@@ -62,7 +62,7 @@ void global_may_alias_domaint::get_rhs_aliases(
   }
   else if(rhs.id()==ID_address_of)
   {
-    get_rhs_aliases_address_of(to_address_of_expr(rhs).op0(), alias_set);
+    get_rhs_aliases_address_of(to_address_of_expr(rhs).object(), alias_set);
   }
 }
 

src/analyses/interval_domain.cpp

@@ -339,25 +339,25 @@ void interval_domaint::assume_rec(
      cond.id()==ID_gt || cond.id()==ID_ge ||
      cond.id()==ID_equal || cond.id()==ID_notequal)
   {
-    assert(cond.operands().size()==2);
+    const auto &rel = to_binary_relation_expr(cond);
 
     if(negation) // !x<y  ---> x>=y
     {
-      if(cond.id()==ID_lt)
-        assume_rec(cond.op0(), ID_ge, cond.op1());
-      else if(cond.id()==ID_le)
-        assume_rec(cond.op0(), ID_gt, cond.op1());
-      else if(cond.id()==ID_gt)
-        assume_rec(cond.op0(), ID_le, cond.op1());
-      else if(cond.id()==ID_ge)
-        assume_rec(cond.op0(), ID_lt, cond.op1());
-      else if(cond.id()==ID_equal)
-        assume_rec(cond.op0(), ID_notequal, cond.op1());
-      else if(cond.id()==ID_notequal)
-        assume_rec(cond.op0(), ID_equal, cond.op1());
+      if(rel.id() == ID_lt)
+        assume_rec(rel.op0(), ID_ge, rel.op1());
+      else if(rel.id() == ID_le)
+        assume_rec(rel.op0(), ID_gt, rel.op1());
+      else if(rel.id() == ID_gt)
+        assume_rec(rel.op0(), ID_le, rel.op1());
+      else if(rel.id() == ID_ge)
+        assume_rec(rel.op0(), ID_lt, rel.op1());
+      else if(rel.id() == ID_equal)
+        assume_rec(rel.op0(), ID_notequal, rel.op1());
+      else if(rel.id() == ID_notequal)
+        assume_rec(rel.op0(), ID_equal, rel.op1());
     }
     else
-      assume_rec(cond.op0(), cond.id(), cond.op1());
+      assume_rec(rel.op0(), rel.id(), rel.op1());
   }
   else if(cond.id()==ID_not)
   {