Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change query IDs in CSV results #284

Open
nck-mlcnv opened this issue Sep 27, 2024 · 3 comments
Open

Change query IDs in CSV results #284

nck-mlcnv opened this issue Sep 27, 2024 · 3 comments
Milestone

Comments

@nck-mlcnv
Copy link
Contributor

The query summary of a task stores the query IDs in the format <querysource-hashcode>;<query-id-inside-of-querysource>. which
may working with the file a bit more difficult. The hashcode should be instead written in a separate column.

Example:

queryID     |
------------|
1218510187:0|

should be instead:

queryID     | query-source |
------------|--------------|
          0 | 1218510187   |
@bigerl
Copy link
Member

bigerl commented Sep 27, 2024

Do you have a example where it is specifically problematic? Because, on the other hand, this makes queryID a unique key for queries even if you have results from different sources in one CSV fil.

@nck-mlcnv
Copy link
Contributor Author

nck-mlcnv commented Oct 1, 2024

Not a specific case, but it just seemed to make more sense to me to split up the query id and the hash of the query-source (also in terms of normalising the table). You could still use both values as the key, as opposed to solely using the queryID row. It was just some random thing that I noticed, I don't know if it is really an issue.

@bigerl
Copy link
Member

bigerl commented Oct 30, 2024

query-index source-hash query-hash
0 1218510187 8263967382

I would suggest to have these columns then.

queryID should generally be replaced with query-index together with, where necessary source-hash. query-hash is an additional information for easier matching of queries within a source or across sources.

@bigerl bigerl added this to the 5.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants