Fix dimming lights in Leorics chamber

[ThomasChr]

Fixes #1410

[ThomasChr]

This does indeed fix #1410.
The problems to me seems that all light Objects save in _oVar1 if their lightsource has already been added to them.
When we are saving the leveldata (SaveLevel()) it doesn't make sense (to me) to save this variable on light objects, because all of their light sources should be added back again when loading the level (LoadGameLevel->LoadLevel())
It does work when using the stairs because in ProcessObjects->UpdateObjectLight we are setting the variable _oVar1 to 0 when light object is far enough away that we don't see it in anymore.

[ThomasChr]

The same thing should happen when Saving and Loading, because there also our torches are loaded with _oVar1 set to 1. But something seems to go another way here because the light sources get added. I'll investigate that further.

[AJenbo]

Converting to a draft as it has draft in the title and i keep getting notifications for it when it's being updated.

[ThomasChr]

... Simply adding Draft: in the title does not work? ...pretty sure in gitlab that does work.
So I'm not quite sure here what to do. My fix should work. But it does seems a little bit too much.
And I think I know why loading from a save does work. Because real savegames (instead of level saves) also save the light sources with them. Those simple level saves don't do that.

So I think the last thing to do would be to check if we are a simple save, in which cases we set all light objects to unseen, or if we are a big save in which case the light objects can be saved as already seen because the lights will also get saved along.

Does that sound feasible?

[AJenbo]

.pretty sure in gitlab that does work.

Yes, but not in github

[AJenbo]

Does that sound feasible?

I'm unable to think about this atm, catch me in a week or so.

[ThomasChr]

@AJenbo Take your time. I think this solution now should work, it won't change anything when saving "real savegames" but it will mark all light objects unseen when saving level change data.
I'm pretty sure I will remember pinging you in a week or so. I think I'll leave this is draft until then.

[ThomasChr]

@AJenbo Care to take a look?

[qndel]

looks good, just change make torches unseen to make dynamic light sources unseen as technically they aren't all torches :D

[ThomasChr]

As usual, you are right @qndel :-)
Thanks for looking into it!

[qndel]

Please don't include issue # in commit - it causes quite a spam on github

[qndel]

This definitely feels like a proper fix, but requires some tweaks. Do valor torches behave the same way? Atm this fixes leoric chamber light issues but might cause new ones - in regular dungeons I believe all stuff like torches etc. is saved into dPreLight, with this PR they all get activated even if you aren't close to them.

To test:
Add this to X hotkey

	keymapper.AddAction({
	    "DebugToggle",
	    'X',
	    [] {
		    SDL_Log("ACTIVE LIGHT COUNT: %d", ActiveLightCount);
		    DebugToggle = !DebugToggle;
	    },
	    [&]() { return true; },
	});

After leaving leoric's tomb without your change, I had 2 active lights, after your change I instantly had 8+ active lights. So the question is if it should affect regular levels at all - if valor torches work fine, I'd only limit it to quest levels.

because I can

[qndel]

Tested valor, it doesn't need this fix so can safely be limited only to quest levels.

[AJenbo]

nice work

[Chance4us]

Many thanks @ThomasChr this one PR is really great.