-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add yellow outline to berserked monsters #3122
Conversation
8b31407
to
4368e67
Compare
Why use a totally different visual indicator rather than just fixing the original indicator? The sprite outline looks totally out of place to me. |
@agris-codes The original indicator (the light source for a berserk monster) has been fixed with my two PRs. The problem is that the light source only allows for 32 light sources in total. And we can‘t change that easily because of savegame compatibility. |
Because light radiance was already used to help unique monsters stand out from regular monsters. Hellfire trashes that by letting the player hand out light sources like candy. |
That issue is largely fixed with your PR where it adds the light at load time, we could allow for more then 32 lights, and not save berserk lights in addition to avoid this being an issue at all (berserkers would not light up if loaded in the original game, would already be the case if they hit the limit)
This was already an issue in Diablo since it also happens with firewalls. |
Yes but no light source was permanent like hellfire's berserk, firewalls expire etc. |
I see that as a separate issue, that has been fixed by removing the light on death. |
Missile light is fine and diminishes nothing. A berserked monster sort of looks like a unique, especially if it's in an adjacent room and all you see is the light source moving around. It's not a good idea for any regular monster to be able to glow in darkness as a spell effect. |
@AJenbo Should we change that bevore 1.3.0? |
No, increasing the lights is to risky, but we can do it right after release. Feel free to prepare a PR for it if you like. |
I agree. Will prepare a PR (which will be very easy), and test it (which will take a little bit of time)... |
Imo we solved the baserk lighting pretty well |
Agreed, and I didn't intend to be dismissive of qndel's proposed fix. The sprite outline looked good technically, but was not a good aesthetic fit. Glad its resolved. |
and remove original buggy light
Resolves #1588
Resolves #1586