Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird death animation after getting killed by a barrel #3473

Closed
vlolteanu opened this issue Nov 10, 2021 · 4 comments · Fixed by #3571
Closed

Weird death animation after getting killed by a barrel #3473

vlolteanu opened this issue Nov 10, 2021 · 4 comments · Fixed by #3571
Assignees
Labels
bug Something isn't working savegame attached vanilla Bugs found also in the original Diablo 1.09b release

Comments

@vlolteanu
Copy link
Contributor

Important information
Linux / c151236, also reproducible with the official release binary

Describe
After getting killed by an exploding barrel, the character briefly flashes standing upright.

To Reproduce
Steps to reproduce the behavior:

  1. Load attached save
  2. Try to get killed by a barrel. The two at the ends of the C-shaped arrangement are explosive.
  3. If you didn't die, load and try again.

Expected behavior
Once down, the character should stay down.

Additional context
single_2.zip

This doesn't happen if you get killed by a monster.

@vlolteanu vlolteanu added bug Something isn't working savegame attached labels Nov 10, 2021
@qndel
Copy link
Member

qndel commented Nov 10, 2021

player.AnimInfo.GetFrameToUseForRendering() for some reason returns frame 1 in the middle of rendering last death frame
Probably somehow related to getting attack animation interrupted by death?

Also who would've thought, it's a vanilla bug :O

@qndel qndel self-assigned this Nov 10, 2021
@qndel qndel added the vanilla Bugs found also in the original Diablo 1.09b release label Nov 10, 2021
@qndel
Copy link
Member

qndel commented Nov 10, 2021

funnydeath

@julealgon
Copy link
Contributor

@qndel does it repro if you are interrupted and killed by a monster as well? Or conversely, if you are killed by a barrel that was broken by a different player?

@qndel
Copy link
Member

qndel commented Nov 12, 2021

@qndel does it repro if you are interrupted and killed by a monster as well? Or conversely, if you are killed by a barrel that was broken by a different player?

No, only when you destroy a barrel, it's caused by the death happening in ProcessPlayers in DoAttack, the animation manages to get 1 frame further than usual because of that and the game attempts to loop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working savegame attached vanilla Bugs found also in the original Diablo 1.09b release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants