docs: add decision minutes for 2019-10-09 meeting #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mohammer5
approved these changes
Oct 11, 2019
Birkbjo
reviewed
Oct 11, 2019
Birkbjo
reviewed
Oct 11, 2019
Birkbjo
approved these changes
Oct 11, 2019
There was a problem hiding this comment.
I think this is an accurate summary of everything that was discussed, but I do have a suggestion to change the "Slow down releases a bit, improve automation" section a bit:
- The initially suggested approach was rejected and we discussed some alternative approaches.
- But no final decision was made reg. to these alternative approaches, we are only going to do some trials.
- IMO this document should not cover the alternative approaches in depth, because the main focus of this document should be a summary of what was decided.
- Instead the alternative approaches should probably be placed in separate issues (see "Help each other stay on topic in a discussion, split side topics into new issues")
I'm afraid that if we keep all the details of these alternative approaches in here, this will just become a place to discuss the pros and cons of each one (see #70 (comment)), and I don't think we should do that here....
|
That makes sense @HendrikThePendric. |
ghost
self-requested a review
ghost
approved these changes
Oct 14, 2019
This was referenced Oct 14, 2019
erikarenhill
approved these changes
Oct 18, 2019
amcgee
requested changes
Oct 18, 2019
|
Sure, go for it.
…On October 18, 2019 2:18:47 PM GMT+02:00, Austin McGee ***@***.***> wrote:
amcgee requested changes on this pull request.
LGTM with just one change - the `[defer release]` PR was merged so we
should probably mention that that is the "conclusion" of the **Defer
the automatic release system** section.
Just ping me if I should make the change to this notes PR
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#70 (review)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
@amcgee I've updated the decision accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dhis2/front-end 👋
Thanks for a constructive meeting.
I took a recording but I forgot to add the sound capture channel to the recording so I have the video, but not the sound. One of these days I will learn how this recording software works and take a job as a broadcaster. 🤦♂
I've re-watched the footage to refresh my memory about what we talked about, and there has been some follow-ups on Slack that have been incorporated.
As always, if I have misrepresented something, hit the "changes requested" button in a review and explain your take on it and we can talk about it. 🌵
If you agree with the decisions documented, hit the "approve" button in a review! ✔️
Resolved notes
Closes #65 (the agenda)
Closes #52
Closes #25