Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build api-test image using buildkit on GitHub #9093

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Oct 20, 2021

seperate it out into its own step so it can be built using
https://docs.docker.com/develop/develop-images/build_enhancements/

so we can take advantage of it building the image faster and enable
caching as well
https://github.com/docker/build-push-action/blob/5e11b373bfed0d8024ef33d1586c675819690e95/docs/advanced/cache.md#github-cache

@teleivo teleivo added the run-api-tests This label will trigger an api-test job for the PR. label Oct 20, 2021
@teleivo teleivo force-pushed the e2e-test-only-buildkit branch from d5d32b1 to 6968a55 Compare October 20, 2021 03:38
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teleivo teleivo marked this pull request as ready for review October 20, 2021 11:17
@teleivo teleivo requested a review from vilkg October 22, 2021 10:04
@stian-sandvold stian-sandvold merged commit 9405f09 into master Oct 26, 2021
@stian-sandvold stian-sandvold deleted the e2e-test-only-buildkit branch October 26, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-tests This label will trigger an api-test job for the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants