You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consolidate Envoy versions into a single canonical file to enable simpler management and avoid missed updates in the future.
This effort is motivated by repeated experience struggling to ensure that we updated Envoy "everywhere" we needed to. Even moreso than managing our Go versions, there's a significant amount of sprawl when it comes to Envoy, and addressing that will enable us to more confidently update versions as well as automate the toil of doing so when new releases are available.
Note that if it weren't for returning full x.y.z Envoy versions in v1/agent/selfoutput, I'm pretty sure we could just store the "major" x.y versions going forward and dynamically test against the latest of each in CI, since we only validate major versions in the consul connect envoy command. For now, I've kept the existing pattern of explicitly source-controlled minor Envoy releases that we'll have to keep updated - but we can at least automate that more effectively now.
I've opened manual backports through 1.15 Ent to ensure that the ENVOY_VERSIONS file is available on all actively tested branches; this is necessary for sourcing in nightly integration tests on main, so required for this PR prior to merge.
This change also includes:
Fix to Go version branch sourcing aligned with this PR (missed in previous Go version work).
Some missed component version updates in integration tests.
I have not removed or changed defunct uses of Envoy in Windows integration tests as I think that would be best accomplished as a separate holistic Windows cleanup PR.
Nightly 1.19 versions match expected (workflow dispatch test branch used to target 1.19 PR branch for sourcing Envoy version to emulate post-1.19-backport nightly run)
Nightly 1.15 versions match expected (workflow dispatch test branch used to target 1.15 PR branch for sourcing Envoy version to emulate post-1.15-backport nightly run)
Description
Consolidate Envoy versions into a single canonical file to enable simpler management and avoid missed updates in the future.
This effort is motivated by repeated experience struggling to ensure that we updated Envoy "everywhere" we needed to. Even moreso than managing our Go versions, there's a significant amount of sprawl when it comes to Envoy, and addressing that will enable us to more confidently update versions as well as automate the toil of doing so when new releases are available.
I've opened manual backports through 1.15 Ent to ensure that the
ENVOY_VERSIONS
file is available on all actively tested branches; this is necessary for sourcing in nightly integration tests onmain
, so required for this PR prior to merge.This change also includes:
I have not removed or changed defunct uses of Envoy in Windows integration tests as I think that would be best accomplished as a separate holistic Windows cleanup PR.
Testing & Reproduction steps
get-envoy-versions
output matches filemain
versions match expectedLocal agent test:
main
PR branch
Follow-ups
Links
Manual backport PRs:
PR Checklist
The text was updated successfully, but these errors were encountered: