Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of docs: Update k8s/connect/create-sameness-groups into release/1.16.x #1290

Open
3 of 4 tasks
dhiaayachi opened this issue Sep 28, 2024 · 0 comments
Open
3 of 4 tasks

Comments

@dhiaayachi
Copy link
Owner

Backport

Overview of commits - Changing the ExportServices CRD name to reflect the partition it refers to

This PR is auto-generated from hashicorp#20317 to be assessed for backporting due to the inclusion of the label backport/1.16.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@krastin
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

A small change to the export group name reflecting the local partition being exported from as defined in the Exported Services Configuration docs.

Testing & Reproduction steps

None

Links

https://developer.hashicorp.com/consul/docs/connect/config-entries/exported-services#configuration

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant