Fix isNormalized
#522
Merged
Fix isNormalized
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #516 00c79f5 and d287f02 added additional simplifications to Dhall, but without a matching change to `isNormalized`. This causes `isNormalized` to falsely report that these expressions are normalized when in fact they can still be normalized. This change fixes that by updating `isNormalized` to match the behavior of `normalize`
|
Note that I'm waiting for #519 to be merged because I'd like to build upon that in this pull request to add a |
... and fix the errors that QuickCheck caught 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516
00c79f5 and
d287f02 added additional simplifications to
Dhall, but without a matching change to
isNormalized. This causesisNormalizedto falsely report that these expressions are normalized whenin fact they can still be normalized. This change fixes that by updating
isNormalizedto match the behavior ofnormalize