Skip to content

Don't URL encode path components #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Don't URL encode path components #2505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc449e
Don't URL encode path components
Gabriella439 Apr 8, 2023
fea4b63
Merge branch 'main' into gabriella/fix_url_encoding
Gabriella439 Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dhall/dhall.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ Common common
transformers >= 0.5.2.0 && < 0.7 ,
unix-compat >= 0.4.2 && < 0.7 ,
unordered-containers >= 0.1.3.0 && < 0.3 ,
uri-encode < 1.6 ,
vector >= 0.11.0.0 && < 0.14

if flag(with-http)
Expand Down
4 changes: 1 addition & 3 deletions dhall/src/Dhall/URL.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,8 @@ import Data.Text (Text)

import Dhall.Syntax (Directory (..), File (..), Scheme (..), URL (..))

import qualified Network.URI.Encode as URI.Encode

renderComponent :: Text -> Text
renderComponent component = "/" <> URI.Encode.encodeText component
renderComponent component = "/" <> component

renderQuery :: Text -> Text
renderQuery query = "?" <> query
Expand Down