Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Verify that device is connected to internet before runnings tests. #2702

Open
gety9 opened this issue Oct 11, 2024 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@gety9
Copy link

gety9 commented Oct 11, 2024

Version and OS
0.46.04, termux

Is your feature request related to a problem? Please describe.
My device wasn't connected to internet and all tests failed (Exception)

Describe the solution you'd like
If device is not connected to internet skip the tests

Additional thoughts:
-, retry internet connection in smaller interval than watch intervals, cause now if you have tests once in 3 hours, and it failes cause of no internet, it will be retried only in 3 hours

@gety9 gety9 added the enhancement New feature or request label Oct 11, 2024
@dgtlmoon
Copy link
Owner

this is too hard, but i think better is like "wait 10 seconds before checking" with some obvious message in the UI?

@gety9
Copy link
Author

gety9 commented Oct 25, 2024

@dgtlmoon

this is too hard, but i think better is like "wait 10 seconds before checking" with some obvious message in the UI?

sounds good, only issue is what if device is out of internet for 30 min? It will check every 10 seconds for 30 min? If it's not expensive device / resources wise then let be it, other wise we can try: extend duration with each try - wait 10 seconds, then wait 60 seconds, then wait 3 min, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants