Fix zero's health endpoint to return json response #8858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested changes
Jun 7, 2023
mangalaman93
changed the title
mangalaman93
requested review from
akon-dey,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
mangalaman93
previously approved these changes
Jun 7, 2023
harshil-goel
reviewed
Jun 8, 2023
jbhamra1
force-pushed
the
jassi/zero_health_issue_5517
branch
from
32950b9
to
3e25acd
Compare
mangalaman93
requested changes
Jun 20, 2023
jbhamra1
force-pushed
the
jassi/zero_health_issue_5517
branch
from
3e25acd
to
9d57a29
Compare
jbhamra1
requested review from
sanjayk-github-dev,
all-seeing-code and
joshua-goldstein
as code owners
mangalaman93
previously approved these changes
Jun 23, 2023
jbhamra1
force-pushed
the
jassi/zero_health_issue_5517
branch
from
77ed794
to
f554eb9
Compare
mangalaman93
requested changes
Jun 28, 2023
jbhamra1
force-pushed
the
jassi/zero_health_issue_5517
branch
from
aebb829
to
ee76626
Compare
mangalaman93
approved these changes
Jun 28, 2023
harshil-goel
approved these changes
Jun 28, 2023
dgraph-bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
Fixes #5517 Zero's /health endpoint just returns OK unlike Alpha's JSON output. ## Problem curl http://alpha-hostname:alpha-http-port/health returns a JSON output whereas, curl http://zero-hostname:zero-http-port/health returns a plain text "OK". ## Solution Added code to return a plain text output ("OK") for the "text/plain" to maintain the backward compatibility and return JSON output for "Accept: application/json" header. Example Output: $ curl http://localhost:58696/health OK $ curl -H "Accept: application/json" http://localhost:58696/health {"instance":"zero","address":"zero1:5080","status":"healthy","version":"v23.0.0-16-g90139243f","uptime":9223372036,"lastEcho":1686137664}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5517 Zero's /health endpoint just returns OK unlike Alpha's JSON output.
Problem
curl http://alpha-hostname:alpha-http-port/health returns a JSON output whereas, curl http://zero-hostname:zero-http-port/health returns a plain text "OK".
Solution
Added code to return a plain text output ("OK") for the "text/plain" to maintain the backward compatibility and return JSON output for "Accept: application/json" header.
Example Output:
$ curl http://localhost:58696/health
OK
$ curl -H "Accept: application/json" http://localhost:58696/health
{"instance":"zero","address":"zero1:5080","status":"healthy","version":"v23.0.0-16-g90139243f","uptime":9223372036,"lastEcho":1686137664}