opt(GraphQL): filter existence queries on GraphQL side instead of using @filter(type) #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
vmrajas
suggested changes
Apr 27, 2021
NamanJain8
added a commit
that referenced
this pull request
Apr 28, 2021
@filter(type) (#7757) For the existence queries we used to do: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n } \n} The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n } \n} This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight. The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM. (cherry picked from commit 690fbbe)
NamanJain8
added a commit
that referenced
this pull request
Apr 28, 2021
@filter(type) (#7757) (#7760) For the existence queries we used to do: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n } \n} The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n } \n} This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight. The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM. (cherry picked from commit 690fbbe)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
@filter(type) (#7757) (#7760) For the existence queries we used to do: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n } \n} The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n } \n} This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight. The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM. (cherry picked from commit 690fbbe) (cherry picked from commit bfc75c3)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
@filter(type) (#7757) (#7760) For the existence queries we used to do: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) @filter(type(Cuisine)) {\n uid \n } \n} The filter operation can be very heavy on dgraph.type as it may store millions of nodes. A better query could be like this: query {\n Cuisine_1(func: eq(Cuisine.name, \"yaMqnmHeov\")) {\n uid dgraph.type \n } \n} This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight. The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM. (cherry picked from commit 690fbbe) (cherry picked from commit bfc75c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GraphQL-1124
A simple GraphQL mutation like:
gets translated to the following existence query
The filter operation can be very heavy on
dgraph.typeas it may store millions of nodes. A better query could be like this:This PR removes the above @filter operation from the existence query and uses the suggested alternate query which is lightweight.
The existence check operation is path critical and this fix is expected to add some performance improvement along with preventing OOM.
This change is