chore(Github Action|CI): add Github Action for testing #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
suggested changes
Mar 28, 2023
.github/workflows/node.js.yml
Outdated
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] | ||
|
|
There was a problem hiding this comment.
we might want to add a cron job @skrdgraph thoughts?
.github/workflows/node.js.yml
Outdated
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [14.x, 16.x, 18.x, 19.x] |
There was a problem hiding this comment.
these are a lot of node versions, is there a particular reason you chose these?
There was a problem hiding this comment.
Same answer as in the dgraph-js repo.
|
Looking good at first glance, just some cosmetic things. Try to make the CI here look like other CI files as much as possible, e.g. https://github.com/dgraph-io/dgraph/blob/main/.github/workflows/ci-dgraph-tests.yml |
joshua-goldstein
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing existing test scripts to bring CI into the repository.
This change is