-
Notifications
You must be signed in to change notification settings - Fork 0
Building libsass/sass-worker won't work? #2
Comments
Can you create a pr with your changes? |
I didn't change a thing, I only:
|
Do you have docker installed and tuning on the background? |
Nop, is that a thing? |
So docker is needed iirc for building emscripten from source |
I just completed downloading, installing Docker.Desktop but it won't work because it requires some feature called hardware assisted virtualization, which my machine does not support. |
@thednp probably you can modify this so it could run in a GitHub action. But honestly I don't see the reason, the versions of libsass and node sass are the latest ones thus the output won't be different (unless if you plan to play around with the emscripten options) |
TBH I was thinking to have have a repository/folder somewhere I can hit |
Hopefully the dart-sass is close to have a native wasm, so all this would be definitely deprecated. (probably you can do that right now if you're willing to fiddle with their build tools: sass/dart-sass#25) |
Thank you again for your time, I'm now going to revamp the color picker to work with a regular Will let you know on the progress. Thanks again. Cheers! |
Sorry to bother man, I've downloaded this on my machine, updated the git and executed the
npm run build
script and it won't complete due to some warning:Same result with
npm run build --force
. Is there anything I need to do in preparation to running this script?Also after update I got notified about some 18 vulnerabilities.
The text was updated successfully, but these errors were encountered: