Skip to content
This repository has been archived by the owner on Sep 25, 2022. It is now read-only.

Building libsass/sass-worker won't work? #2

Open
thednp opened this issue Feb 23, 2022 · 10 comments
Open

Building libsass/sass-worker won't work? #2

thednp opened this issue Feb 23, 2022 · 10 comments

Comments

@thednp
Copy link

thednp commented Feb 23, 2022

Sorry to bother man, I've downloaded this on my machine, updated the git and executed the npm run build script and it won't complete due to some warning:

Warning: Command failed: (cd libsass && /bin/bash ./prepare.sh "3.6.5")
The system cannot find the path specified.
 Use --force to continue.

Same result with npm run build --force. Is there anything I need to do in preparation to running this script?

Also after update I got notified about some 18 vulnerabilities.

@dgrammatiko
Copy link
Owner

Can you create a pr with your changes?

@thednp
Copy link
Author

thednp commented Feb 23, 2022

I didn't change a thing, I only:

  • downloaded the zip,
  • opened in VisualCode,
  • ran npm run update to install and update
  • ran npm run build

@dgrammatiko
Copy link
Owner

Do you have docker installed and tuning on the background?

@thednp
Copy link
Author

thednp commented Feb 23, 2022

Nop, is that a thing?

@dgrammatiko
Copy link
Owner

So docker is needed iirc for building emscripten from source

@thednp
Copy link
Author

thednp commented Feb 23, 2022

I just completed downloading, installing Docker.Desktop but it won't work because it requires some feature called hardware assisted virtualization, which my machine does not support.

@dgrammatiko
Copy link
Owner

@thednp probably you can modify this so it could run in a GitHub action. But honestly I don't see the reason, the versions of libsass and node sass are the latest ones thus the output won't be different (unless if you plan to play around with the emscripten options)

@thednp
Copy link
Author

thednp commented Feb 23, 2022

TBH I was thinking to have have a repository/folder somewhere I can hit npm update & npm run build to get the latest sass compiler without asking you "please update".

@dgrammatiko
Copy link
Owner

Hopefully the dart-sass is close to have a native wasm, so all this would be definitely deprecated. (probably you can do that right now if you're willing to fiddle with their build tools: sass/dart-sass#25)

@thednp
Copy link
Author

thednp commented Feb 23, 2022

Thank you again for your time, I'm now going to revamp the color picker to work with a regular <input> in a way to make it easy to add a <joomla-color-picker> CE with <slot> later on (I've learned how to do that meanwhile, and I didn't get you back then).

Will let you know on the progress.

Thanks again. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants