fix: url decoding in ic-certified-assets #3767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The url_decode function in ic-certified-assets didn't correctly decode some special characters.
The code has been changed to decode the "percent strings" to bytes instead of
char
and then convert the bytes to utf8 strings.This change is using https://crates.io/crates/percent-encoding - We can then reuse the same library in the response verification library. The crate complies with: https://url.spec.whatwg.org/#percent-decode
Fixes # (SDK-1412)
How Has This Been Tested?
Fixed the existing unit tests and added new unit tests.
One of the tests was broken:
Outputs:
The correct encoding for
æ
is over two bytes%C3%A6
Checklist: