Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax error in doctest #544

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

syntax error in doctest #544

wants to merge 4 commits into from

Conversation

v2i0s2h2
Copy link

missing Double quotes

@dfinity-droid-prod
Copy link

Dear @v2i0s2h2,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement ↩

rvanasa
rvanasa approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

crusso
crusso approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crusso crusso enabled auto-merge (squash) June 27, 2023 10:34
@ggreif ggreif changed the title syntex error syntax error in doctest Jun 27, 2023
@sa-github-api
Copy link

Dear @v2i0s2h2,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanasa rvanasa rvanasa approved these changes

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
cla:pending external-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v2i0s2h2 @sa-github-api @crusso @rvanasa