RFC/WIP: Allow debugging across multiple contexts#32
Open
sachera wants to merge 9 commits intodfeyer:masterfrom
Open
RFC/WIP: Allow debugging across multiple contexts#32sachera wants to merge 9 commits intodfeyer:masterfrom
sachera wants to merge 9 commits intodfeyer:masterfrom
Conversation
…ckage>/Classes/<path_and_file>.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use the debug proxy in Testing code I hit multiple problems resolved in this merge request. Due to changes in the applications CLI this is a breaking change.
The xdebug_port and context parameters are replaced with a single xdebug parameter which has the form "Context:Post,Contex2:Port2,..." e.g. "Testing:9001,Development:9003". With this change the tests can be configured to use another xdebug port and the proxy can then use the same context the tests use to determine class names, while the port the ide listens on stays the same.
There are further small changes (more logging, slightly different Dockerfile to speed up repeatedly building the container) and some changes in the actual mapping code which were required on my machine to ensure the file paths are resolved reliably.
The README.md is not yet changed. Before changing it I wanted your feedback on this change in general and maybe adapt it if required.